feat: Allow retry strategy on non-leaf nodes, eg for step groups. Fixes #1891 #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markterm
force-pushed
the
retry-groups
branch
from
0bca8b6 to
2c30998
Compare
markterm
force-pushed
the
retry-groups
branch
from
8ccd916 to
b89f339
Compare
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
=========================================
Coverage ? 11.43%
=========================================
Files ? 71
Lines ? 27903
Branches ? 0
=========================================
Hits ? 3192
Misses ? 24305
Partials ? 406
Continue to review full report at Codecov.
|
alexec
reviewed
Dec 27, 2019
|
Sure - are there any specific scenarios you're thinking of other than the one I already created? |
|
@jessesuen do you want to review this one? Or at least provide commentary on the impact on removing this constraint? |
whynowy
reviewed
Jan 2, 2020
alexec
changed the title
|
@mark9white I've tried to fix the conflict - but I think I've failed to do a good job - if you still want this - do you want to take a look? |
markterm
force-pushed
the
retry-groups
branch
from
78b5ca4 to
ab2404a
Compare
markterm
force-pushed
the
retry-groups
branch
from
ab2404a to
a4f72b2
Compare
|
@alexec I've fixed the conflict |
alexec
approved these changes
Feb 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234". Why? for the release notes.Fixes #1891